All checks were successful
Desktop source guards / guards (push) Successful in 5s
dev-67: приложение снова закрывалось при первом удалении. Стек тот же: QWidget::setParent -> QWidgetPrivate::recreate -> WM_DESTROY главного окна. Причина в том, как Qt ищет окно для переключения на RHI: closestParentWidgetWithWindowHandle() идёт вверх по родителям, пока не найдёт предка с нативным окном. У накладки своего окна ещё нет, поэтому поиск перешагнул через неё и дошёл до её Qt-родителя, то есть до главного окна. Накладка теперь окно верхнего уровня без Qt-родителя. Связь с главным окном через владельца Windows (GWLP_HWNDPARENT, как MainWindow делает для панели задач), заданного до первого показа: накладка остаётся над владельцем, прячется вместе с ним и не попадает на панель задач. WA_QuitOnClose выключен. Гард в test_zastogram_diag.py. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
199 lines
9.4 KiB
Python
199 lines
9.4 KiB
Python
from pathlib import Path
|
||
|
||
|
||
SOURCES = Path(__file__).resolve().parents[1]
|
||
ROOT = SOURCES.parent
|
||
|
||
|
||
def source(relative):
|
||
return (SOURCES / relative).read_text(encoding="utf-8")
|
||
|
||
|
||
def between(text, start, end):
|
||
begin = text.index(start)
|
||
return text[begin:text.index(end, begin)]
|
||
|
||
|
||
def test_module_is_built():
|
||
cmake = (ROOT / "CMakeLists.txt").read_text(encoding="utf-8")
|
||
assert "core/zsg_diag.cpp" in cmake
|
||
assert "core/zsg_diag.h" in cmake
|
||
|
||
|
||
def test_link_map_is_produced():
|
||
# Без карты отчёт о падении — только смещения, имён функций не получить.
|
||
cmake = (ROOT / "CMakeLists.txt").read_text(encoding="utf-8")
|
||
assert "/MAP:$<TARGET_FILE_DIR:Telegram>/Telegram.map" in cmake
|
||
|
||
|
||
def test_breakpad_reaches_the_module():
|
||
crash = source("core/crash_reports.cpp")
|
||
callback = between(
|
||
crash,
|
||
"bool DumpCallback(const wchar_t*",
|
||
"#endif // !Q_OS_MAC || MAC_USE_BREAKPAD")
|
||
assert "Core::ZsgDiag::OnBreakpadException(exinfo)" in callback
|
||
# Обработчик ставится в конце StartCatching, а SIGABRT — после Start().
|
||
catching = between(crash, "void StartCatching()", "bool WriteMinidumpNow()")
|
||
assert "Core::ZsgDiag::Install()" in catching
|
||
assert "bool WriteMinidumpNow()" in crash
|
||
sandbox = source("core/sandbox.cpp")
|
||
start = sandbox.index("CrashReports::Start()")
|
||
assert sandbox.index("ZsgDiag::Arm()", start) > start
|
||
assert sandbox.index("ZsgDiag::ReportPreviousCrashes()", start) > start
|
||
|
||
|
||
def test_dumps_carry_memory():
|
||
crash = source("core/crash_reports.cpp")
|
||
assert "MiniDumpWithIndirectlyReferencedMemory" in crash
|
||
assert "MINIDUMP_TYPE(MiniDumpNormal)" not in crash
|
||
|
||
|
||
def test_every_kind_of_death_is_covered():
|
||
diag = source("core/zsg_diag.cpp")
|
||
assert "std::set_terminate(TerminateHandler)" in diag
|
||
assert "std::signal(SIGABRT, AbortHandler)" in diag
|
||
assert "AddVectoredExceptionHandler(1, VectoredHandler)" in diag
|
||
for code in ("0xC00000FDUL", "0xC0000374UL", "0xC0000409UL"):
|
||
assert code in diag
|
||
# Реальный стек по данным развёртывания образа, а не угадывание по стеку.
|
||
assert "RtlVirtualUnwind" in diag
|
||
|
||
|
||
def test_exits_are_traced_with_a_stack():
|
||
# Выход приложения — не падение: ни дампа, ни отчёта. Единственный след —
|
||
# кто попросил выйти. Все выходы идут через Core::Quit.
|
||
app = source("core/application.cpp")
|
||
body = between(app, "void Quit(QuitReason reason)", "bool Quitting()")
|
||
assert 'ZsgDiag::TraceStack("quit requested"' in body
|
||
assert body.index("TraceStack(") < body.index("QuitAttempt()")
|
||
window = source("platform/win/main_window_win.cpp")
|
||
body = between(window, "void MainWindow::destroyedFromSystem()", "bool MainWindow::setDwmThumbnail(")
|
||
assert "TraceStack(" in body
|
||
assert body.index("TraceStack(") < body.index("Core::Quit()")
|
||
thanos = source("ui/effects/thanos_effect.cpp")
|
||
assert "thanos: creating surface" in thanos
|
||
assert "thanos: surface created" in thanos
|
||
|
||
|
||
def test_delete_animation_never_touches_the_main_window_on_windows():
|
||
# Первое удаление в сессии добавляло RHI-виджет эффекта в главное окно, Qt
|
||
# пересоздавал его хэндл, WM_DESTROY превращался в Core::Quit() (dev-63..65).
|
||
# Поверхность эффекта живёт в отдельном прозрачном окне-накладке, которое
|
||
# создаётся вместе со своим GPU-потомком и не пересоздаётся.
|
||
thanos = source("ui/effects/thanos_effect.cpp")
|
||
body = between(thanos, "void ThanosEffect::ensureSurface()", "void ThanosEffect::showSurface()")
|
||
assert "#ifdef Q_OS_WIN" in body
|
||
assert "new ThanosOverlay(_parent)" in body
|
||
# Родитель поверхности — накладка, а не главное окно.
|
||
assert "GL::CreateSurface(\n\t\tsurfaceParent," in body
|
||
assert body.index("new ThanosOverlay") < body.index("GL::CreateSurface")
|
||
show = between(thanos, "void ThanosEffect::showSurface()", "void ThanosEffect::hideSurface()")
|
||
assert "_overlay->present()" in show
|
||
assert "_overlay->dismiss()" in between(thanos, "void ThanosEffect::hideSurface()", "void ThanosEffect::finishNow()")
|
||
# Освобождение: поверхность раньше накладки, накладка раньше главного окна.
|
||
dtor = between(thanos, "ThanosEffect::~ThanosEffect()", "QWidget *ThanosEffect::surfaceWidget()")
|
||
assert dtor.index("_surface = nullptr") < dtor.index("delete _overlay.data()")
|
||
supported = between(thanos, "bool ThanosEffect::Supported()", "bool ThanosEffect::WindowVisible(")
|
||
assert 'qEnvironmentVariableIsSet("ZSG_DISABLE_THANOS")' in supported
|
||
assert "ZSG_ENABLE_THANOS" not in thanos
|
||
controller = source("ui/effects/thanos_effect_controller.cpp")
|
||
body = between(controller, "void ThanosEffectController::captureItemsBatch(", "auto anyFound")
|
||
assert "ThanosEffect::Supported()" in body
|
||
|
||
|
||
def test_thanos_overlay_has_no_qt_parent():
|
||
# dev-67: с главным окном как Qt-родителем накладки Qt при добавлении
|
||
# RHI-виджета искал ближайшего предка с нативным окном, перешагнул через
|
||
# накладку (у неё ещё нет хэндла) и пересоздал ГЛАВНОЕ окно. Родитель — только
|
||
# нативный владелец (GWLP_HWNDPARENT).
|
||
overlay = source("ui/effects/zsg_thanos_overlay.cpp")
|
||
ctor = between(overlay, "ThanosOverlay::ThanosOverlay(", "void ThanosOverlay::syncGeometry()")
|
||
assert ": QWidget(\n\tnullptr, // No Qt parent" in ctor
|
||
present = between(overlay, "void ThanosOverlay::present()", "void ThanosOverlay::dismiss()")
|
||
assert "GWLP_HWNDPARENT" in present
|
||
assert present.index("GWLP_HWNDPARENT") < present.index("show();")
|
||
assert "WA_QuitOnClose, false" in overlay
|
||
|
||
|
||
def test_thanos_overlay_cannot_steal_focus_or_input():
|
||
overlay = source("ui/effects/zsg_thanos_overlay.cpp")
|
||
for flag in ("Qt::Tool", "Qt::WindowDoesNotAcceptFocus", "Qt::WindowTransparentForInput"):
|
||
assert flag in overlay, flag
|
||
for attr in ("WA_TranslucentBackground", "WA_ShowWithoutActivating", "WA_TransparentForMouseEvents"):
|
||
assert attr in overlay, attr
|
||
# Накладка следит за главным окном.
|
||
assert "QEvent::Move" in overlay and "QEvent::Resize" in overlay
|
||
cmake = (ROOT / "CMakeLists.txt").read_text(encoding="utf-8")
|
||
assert "ui/effects/zsg_thanos_overlay.cpp" in cmake
|
||
assert "ui/effects/zsg_thanos_overlay.h" in cmake
|
||
|
||
|
||
def test_selftest_is_opt_in():
|
||
diag = source("core/zsg_diag.cpp")
|
||
body = between(diag, "void RunSelfTest()", "} // namespace\n\nvoid Install()")
|
||
assert body.index("isEmpty()") < body.index("std::abort()")
|
||
assert "ZSG_DIAG_SELFTEST" in diag
|
||
|
||
|
||
def test_signal_handler_chains_the_previous_one():
|
||
diag = source("core/zsg_diag.cpp")
|
||
body = between(diag, "void AbortHandler(", "// First-chance look")
|
||
assert "PreviousAbort(sig)" in body
|
||
|
||
|
||
def test_report_path_does_not_allocate():
|
||
diag = source("core/zsg_diag.cpp")
|
||
body = between(diag, "void WriteReport(", "// Asks Breakpad")
|
||
for forbidden in ("QString", "QFile", "new ", "std::string", "LOG("):
|
||
assert forbidden not in body, forbidden
|
||
|
||
|
||
def test_old_reports_reach_the_log():
|
||
diag = source("core/zsg_diag.cpp")
|
||
body = between(diag, "void ReportPreviousCrashes()", "void Note(")
|
||
assert "LOG((" in body
|
||
assert ".reported" in body
|
||
|
||
|
||
def test_delete_path_leaves_breadcrumbs():
|
||
histories = source("data/data_histories.cpp")
|
||
body = between(
|
||
histories,
|
||
"void Histories::deleteMessages(const MessageIdsList &ids",
|
||
"int Histories::sendRequest(")
|
||
for note in ("delete: begin", "delete: destroying local items", "delete: done"):
|
||
assert note in body
|
||
assert "ZsgDiag::Scope" in body
|
||
history = source("history/history.cpp")
|
||
body = between(history, "void History::destroyMessage(", "bool History::hasE2ECloudGroupCarrier")
|
||
assert "ZsgDiag::Scope" in body
|
||
session = source("data/data_session.cpp")
|
||
assert "server delete: begin" in session
|
||
assert "Session::notifyItemsAboutToBeDestroyed" in session
|
||
box = source("boxes/delete_messages_box.cpp")
|
||
assert "delete: box confirmed" in box
|
||
|
||
|
||
def test_notification_gate_survives_merges():
|
||
# upstream d23928eefa: без этого условия clearFromItem вызывается для
|
||
# сообщений, которые не могут держать уведомление.
|
||
history = source("history/history.cpp")
|
||
body = between(history, "void History::destroyMessage(", "bool History::hasE2ECloudGroupCarrier")
|
||
assert "if (CanHoldItemNotification(item))" in body
|
||
assert body.index("CanHoldItemNotification(item)") < body.index("clearFromItem(item)")
|
||
|
||
|
||
def test_release_script_keeps_the_map():
|
||
script = (ROOT.parent.parent / "zsg-release.sh")
|
||
if not script.exists():
|
||
return
|
||
text = script.read_text(encoding="utf-8")
|
||
assert "Telegram.map" in text
|
||
assert "symbols" in text
|
||
|
||
|
||
if __name__ == "__main__":
|
||
for name, value in list(globals().items()):
|
||
if name.startswith("test_") and callable(value):
|
||
value()
|